-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLIP GOV-291: Removing decommissioned nodes #292
Open
vishalchangrani
wants to merge
4
commits into
main
Choose a base branch
from
vishalchangrani-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3e78508
Create 20240930-removing-decommisioned-nodes.md
vishalchangrani 9a4b77a
Update 20240930-removing-decommisioned-nodes.md
vishalchangrani 7cbc25f
Update governance/20240930-removing-decommisioned-nodes.md
vishalchangrani f20207c
adding transaction ID
vishalchangrani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
--- | ||
status: Proposed | ||
flip: GOV-291 | ||
authors: Vishal Changrani | ||
sponsors: Vishal Changrani | ||
updated: 2024-09-30 | ||
--- | ||
|
||
# FLIP GOV-291: Removing decommissioned nodes | ||
|
||
### Proposal | ||
|
||
1. The verification node with node ID `1cf032dd5b3cf9a63943e1f04472bb57cc1240d5cdd86c5fde05b4dabf8b1e7a` is no longer running. | ||
The node was staked through BlockDaemon. The customer needs to unstake the node but is unreachable as per BlockDaemon. | ||
The proposal is to remove the node from the approved list of node IDs via a transaction submitted by the service committee. | ||
This will remove the node from the network in the next epoch. | ||
|
||
2. The access node with node ID `6b9038227f6774f632f7481a2d4d82d6da5efc5fbceb1756fbfc590112231a5b` is no longer running. | ||
The node was staked by Metrika who no longer intends to run the node. | ||
Even though access nodes no longer have to be added to the approved list of nodes, this node was added to the network before the launch of permissionless access nodes and therefore had to be added to the approved list back then. | ||
|
||
### [Issue](https://github.com/onflow/flips/issues/291) | ||
vishalchangrani marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
### [Forum Post](fourm post: https://forum.flow.com/t/flip-gov-291-remove-two-nodes-from-the-approved-list-of-nodes/6599) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What transaction are you planning on using for this? I don't see that mentioned anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plan to use this transaction: https://github.com/onflow/service-account/blob/main/templates/remove_approved_nodes.cdc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put that in the FLIP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added link to transaction script and the actual transaction that was submitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you preview review?