-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows path fix #1190
Windows path fix #1190
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
=======================================
Coverage 38.40% 38.40%
=======================================
Files 38 38
Lines 1940 1940
=======================================
Hits 745 745
Misses 1107 1107
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
6043877
to
6d35468
Compare
f750b9b
to
193ff50
Compare
193ff50
to
af97103
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick review. Great work. Left some comments. The most important feedback I have is to add a test that validates the persisting and loading of different path styles (unix, windows)
d7eabe6
to
7ee66b4
Compare
Closes #1183
Description
This fixes bugs related to Windows path formatting. We were using the
"path"
package in a few places that should have been using"path/filepath"
.Some issues with this were more theoretical and didn't seem to surface yet (absolute paths like
C:/foo/bar
would not be recognized as absolute). But most critically the mixing of"path"
and"path/filepath"
meant that when doing comparisons/dictionary lookups to see if paths were equivalent the different format would result in two paths not matching (this is what broke deployment).The PR also ensures that all paths written to
flow.json
are in UNIX format for cross-platform compatibility. This is the pattern adopted by NPM in thepackage.json
file.For contributor use:
master
branchFiles changed
in the Github PR explorer