-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Generator #1772
Refactor Generator #1772
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1772 +/- ##
==========================================
+ Coverage 29.65% 29.73% +0.08%
==========================================
Files 89 94 +5
Lines 5197 5176 -21
==========================================
- Hits 1541 1539 -2
+ Misses 3469 3458 -11
+ Partials 187 179 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jribbink You tested this manually with |
Yup. No regressions. It fixes some issues in scripts/tx/test templates with missing values as well. |
Closes #1774
Description
Most of the work is just reoganizing logic
Generator.generate
function. This logic was all moved to the TemplateType structs. This helps us generalize a bit better without needing special handling for each new type (i.e. README.md, tests, and anything else in the future.I feel like this could be potentially abstracted further by breaking the template files themselves out of the generator, but probably out of scope for this PR/unnecessary right now and I think what's been changed in this PR is already an improvement.
For contributor use:
master
branchFiles changed
in the Github PR explorer