Handle missing EVM block event in backfill #661
Conversation
m-Peter
requested review from
janezpodhostnik,
peterargue and
zhangchiqing
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
m-Peter
force-pushed
the
mpeter/events-backfill-handle-missing-blocks
branch
from
79e5010
to
49dd1a8
Compare
| if len(transactions) != len(blocks) { | ||
| return models.BlockEvents{}, fmt.Errorf("transactions and blocks have different length") | ||
| } | ||
|
|
||
| // sort both, just in case | ||
| sort.Slice(blocks, func(i, j int) bool { | ||
| return blocks[i].Height < blocks[j].Height | ||
| }) | ||
| sort.Slice(transactions, func(i, j int) bool { | ||
| return transactions[i].Height < transactions[j].Height | ||
| }) |
There was a problem hiding this comment.
transactions and blocks should each have exactly 1 item since you are only searching a single block.
| } | ||
|
|
||
| // append the transaction events to the block events | ||
| // first we sort all the events in the block, by their TransactionIndex, |
There was a problem hiding this comment.
it doesn't hurt to resort, but the events returned from the API should already be sorted by tx index and event index
| currentHeight := block.Height | ||
| transactionEvents := make([]flow.Event, 0) | ||
|
|
||
| for evmEvents.Err != nil && errors.Is(evmEvents.Err, errs.ErrMissingBlock) { |
There was a problem hiding this comment.
if evmEvents has an error, would retrying fix it? if it doesn't, this will loop forever
| return txEvents[i].EventIndex < txEvents[j].EventIndex | ||
| }) | ||
| transactionEvents = append(transactionEvents, txEvents...) | ||
| blocks[i].Events = transactionEvents |
There was a problem hiding this comment.
this overwrite the block events, not append to them
m-Peter
force-pushed
the
mpeter/events-backfill-handle-missing-blocks
branch
from
49dd1a8
to
55a0155
Compare
Description
The new back-fill mechanism, that uses plain-old gRPC APIs, such as
GetEventsForHeightRange, needs to handle the case where anEVM.BlockExecutedevent might be missing. This is a special case formainnet, where it occurred due to the system chunk transaction failure.For contributor use:
masterbranchFiles changedin the Github PR explorer