Skip to content

Commit

Permalink
Merge pull request #6419 from onflow/alex/log-update
Browse files Browse the repository at this point in the history
minor revision of log, to clarify the root causes of likely benign error log
  • Loading branch information
AlexHentschel authored Sep 13, 2024
2 parents 50e5c3a + cbc4df1 commit 2a443de
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion engine/common/follower/compliance_core.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,11 @@ func (c *ComplianceCore) OnBlockRange(originID flow.Identifier, batch []*flow.Bl
// a critical liveness assumption - see EpochCommitSafetyThreshold in protocol.Params for details.
// -> In this case, it is ok for the protocol to halt. Consequently, we can just disregard
// the block, which will probably lead to this node eventually halting.
log.Err(err).Msg("unable to validate proposal with view from unknown epoch")
log.Err(err).Msg(
"Unable to validate proposal with view from unknown epoch. While there is noting wrong with the node, " +
"this could be a symptom of (i) the node being severely behind, (ii) there is a byzantine proposer in " +
"the network, or (iii) there was no finalization progress for hundreds of views. This should be " +
"investigated to confirm the cause is the benign scenario (i).")
return nil
}
return fmt.Errorf("unexpected error validating proposal: %w", err)
Expand Down

0 comments on commit 2a443de

Please sign in to comment.