Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] Implement program recovery for fungible tokens #6278

Merged
merged 8 commits into from
Jul 31, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jul 29, 2024

Work towards: onflow/cadence#3480

Use the new program recovery feature of Cadence and add support for fungible tokens.

See onflow/flips#283

Until the FLIP got approved, the feature is only enabled on all networks except Mainnet, for testing purposes.

@turbolent turbolent requested review from a team July 29, 2024 21:53
@turbolent turbolent self-assigned this Jul 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 4.13223% with 116 lines in your changes missing coverage. Please review.

Project coverage is 41.47%. Comparing base (c158096) to head (0e6de67).

Files Patch % Lines
fvm/environment/program_recovery.go 0.00% 107 Missing ⚠️
fvm/environment/facade_env.go 33.33% 6 Missing ⚠️
...md/util/ledger/util/migration_runtime_interface.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6278      +/-   ##
==========================================
- Coverage   41.51%   41.47%   -0.05%     
==========================================
  Files        2000     2001       +1     
  Lines      142580   142695     +115     
==========================================
- Hits        59189    59179      -10     
- Misses      77217    77338     +121     
- Partials     6174     6178       +4     
Flag Coverage Δ
unittests 41.47% <4.13%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fvm/environment/program_recovery.go Outdated Show resolved Hide resolved
@turbolent turbolent marked this pull request as ready for review July 30, 2024 22:52
@turbolent turbolent requested a review from SupunS July 30, 2024 22:53
@turbolent
Copy link
Member Author

Updated the PR:

  • The FVM feature is now gated and only enabled on all networks except Mainnet
  • The replacement Fungible Token implementation is now updated to conform to the latest FungibleToken standard
  • Added a test case for contract checking in the Cadence 1.0 migration

@turbolent turbolent added this pull request to the merge queue Jul 31, 2024
Merged via the queue into master with commit 5884847 Jul 31, 2024
55 checks passed
@turbolent turbolent deleted the bastian/fungible-token-program-recovery branch July 31, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants