-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decoder for FlowFees.FeesDeducted event #6304
base: master
Are you sure you want to change the base?
Add decoder for FlowFees.FeesDeducted event #6304
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6304 +/- ##
==========================================
+ Coverage 41.50% 42.51% +1.01%
==========================================
Files 2013 2066 +53
Lines 143577 191577 +48000
==========================================
+ Hits 59590 81450 +21860
- Misses 77813 103456 +25643
- Partials 6174 6671 +497
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can you also add a test please? |
@janezpodhostnik, I'm a bit confused about how to approach the test. I can write a simple test that creates such an event structure and decodes it. Would it be any useful doing it? e.g.
where
|
Yeah initially I had something like what you described in mind, but you are correct that that would basically not be testing much. |
This will be used in flow EVM gateway and this is the place where we put such decoders before