Adds NFTStorefrontV2 and USDCFlow to bootstrapping
#6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
requested review from
janezpodhostnik and
zhangchiqing
as code owners
|
Good idea to add these contracts! If the goal is to add these for mostly developer convenience, then the Emulator might be a better place to add this. Not sure if customizing/extending the bootstrapping is already possible so it can be done in the Emulator alone – if not maybe that's something that should be done here in flow-go, and then what the PR currently does (adding the contracts) should be moved to the Emulator. |
joshuahannan
force-pushed
the
add-usdc-to-bootstrap
branch
from
7009009
to
16708af
Compare
|
@turbolent yeah this never realized unfortunately #2812 maybe we can reopen the issue and then move things to emulator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes onflow/flow-emulator#535
Adds the
NFTStorefrontV2andUSDCFlowsmart contracts to the flow-go bootstrapping so they are automatically deployed to the emulator. Will make it easier for developers to test with these contracts without having to deploy them themselves.