-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Refactor REST Routes Package #6616
[Access] Refactor REST Routes Package #6616
Conversation
…drukhiv/6615-rest-refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6616 +/- ##
==========================================
- Coverage 41.19% 41.19% -0.01%
==========================================
Files 2052 2052
Lines 182215 182219 +4
==========================================
- Hits 75072 75070 -2
- Misses 100850 100856 +6
Partials 6293 6293
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. only comment is about switching to using strings for payload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #6615
Context
This PR introduces a significant restructuring of the
access/rest
folder, enhancing modularity and clarity.http
andWebSocket
components intohttp
andwebsockets
directories, simplifying maintenance and readability.rest/common
package.RouterBuilder
implementation is separated from all routes and moved torest/router
.http
andws
routes are now inhttp_routes.go
andws_routes.go
, respectively.v1/subscribe_events
route is moved into thewebsocket/legacy
folder to separate futureWebSocket
implementations.