Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate variable declaration #231

Closed

Conversation

bartolomej
Copy link
Contributor

@bartolomej bartolomej commented Sep 5, 2024

Description

I found a duplicate variable declaration in some Cadence script:

error: cannot redeclare constant: `bridgedMetadata` is already declared
   --> 2230f332d892ed9b87ca31d2f35e06e2eea941a965faafc5deb73b29052941b2:129:8
    |
129 |     let bridgedMetadata = MetadataViews.getEVMBridgedMetadata(nft)!
    |         --------------- previously declared here
   ... 
    |
131 |     let bridgedMetadata = MetadataViews.getEVMBridgedMetadata(nft)!
    |         ^^^^^^^^^^^^^^^

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels
  • Update the version in package.json when there is a change in the smart contracts

Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you run make test to build the assets and make sure all the tests are passing and push your changes again?

@joshuahannan
Copy link
Member

Haven't heard anything back yet, so I just worked the change into this PR: #233

Thanks for pointing this out!

@ksvnar
Copy link

ksvnar commented Sep 28, 2024

Спасибо вам очень хорошо

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants