Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cadence 1.0 refactor #19

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Cadence 1.0 refactor #19

merged 8 commits into from
Sep 17, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Aug 7, 2024

Closes: #18

All contracts passed local migration

[
    {
        "kind": "contract-update-success",
        "account_address": "0xf8d6e0586b0a20c7",
        "contract_name": "CoinToss"
    },
    {
        "kind": "contract-update-success",
        "account_address": "0xf8d6e0586b0a20c7",
        "contract_name": "Xorshift128plus"
    }
]

And staged on Testnet and Mainnet in transactions:

  • Testnet
    • Xorshift128plus - 6a5e9273a64b774021d3f45d5ddee0297889e365c61d912b22c65fd466c56389
    • CoinToss - c61c036cdadc361eef74e3954a7d8dd310f247808e27b97df55e88ce254f9289
  • Mainnet
    • Xorshift128plus - bd3b33da216b2bd4e2c3e2cde45a585bb92348bb44c4030fb1e4328fafce16b4

@sisyphusSmiling sisyphusSmiling self-assigned this Aug 7, 2024
@sisyphusSmiling sisyphusSmiling changed the base branch from cadence-1 to main August 7, 2024 01:20
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review August 7, 2024 01:27
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner August 7, 2024 01:27
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't critical, but maybe we could update the error messages here to be extra descriptive as part of this PR just to get it out of the way? No worries if you don't have the bandwidth right now

@sisyphusSmiling
Copy link
Contributor Author

good call, updated in ee993aa

@sisyphusSmiling sisyphusSmiling merged commit 9dda821 into main Sep 17, 2024
1 check passed
@sisyphusSmiling sisyphusSmiling deleted the cadence-1-refactor branch September 17, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Cadence 1.0 Refactor & Staging
3 participants