Windows Acrylic Background #577
Conversation
There was a problem hiding this comment.
Feedback on the acrylic:
WOAH this looks sick! It works on Mac too. It's very subtle which is so nice. Super cool!
Feedback on the layers panel
- It seems like the layers panel background is too transperant. Maybe things were changed when you added in the acrylic effect, but it's hard to read the text on the sidepanel now. See below.
- It seems like the layer's have an abupt ending depending on the length of the string or the string continues too far. See the screenshot below:
- The Icons look really good on light and dark. One thing for specifically selected classes, is that the icons also need to be white / active or whatever the class is along with the text. See if you can add that class in for that icon.
|
I'll have a look at the layers panel background and see why it's abruptly ending as well. As for the icons, I was wondering how I should style the header icons because the H and the layer number are coloured differently so, when the icon is active, do I colour both the H and the number active with the same colour? |
I think for the case when they are selected they can both be the same color (white/active) just for maximum contrast against the color background. When they aren't selected, I like the half-tone coloring, but you tell me if that's too tough to engineer. |
|
@drfarrell I've fixed both, the issue where in the layers panel background was too transparent and also that of layers having an abrupt ending depending on the length of the string. |
|
Performance didn't seem to degrade on Mac though I can't tell on my version. Otherwise looks good! Deferring to @drfarrell for the final review. |
Description
This PR includes background changes that make the acrylic background possible on Windows. It might work on MacOS as well if there are no unintended side-effects.
What is the purpose of this pull request?