Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all specs passing integrated server side specs with hyper-spec #85

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

catmando
Copy link
Collaborator

All specs pass if you run bundle exec rake

However I do not understand how spec/runner.rb is supposed to work, and its just failing with some message about chomp.

Not sure how to fix that.

@catmando catmando requested a review from hmdne January 21, 2021 00:10
@catmando
Copy link
Collaborator Author

@hmdne updated the flag to be server_side_test per your request, and did a little more cleanup and comments.

@catmando
Copy link
Collaborator Author

catmando commented Feb 2, 2021

okay, so hyper-spec now will run on Rack, and so that is cleaned up, and while I was working on that, somebody at the slack site found some bugs in canvas which I fixed, and added some specs.

@hmdne
Copy link
Member

hmdne commented Jul 23, 2021

I did a different approach, by making default mean selenium_chrome. I will try to backport from this PR as much as possible in the following days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants