Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker compose deployment for ROCm example #1054

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

astafevav
Copy link

@astafevav astafevav commented Nov 1, 2024

Type of change

  • Added docker compose deployment example for AMD ROCm systems
  • Added Readme for compose deployment on AMD ROCm systems
  • Added tests for compose deployment on AMD ROCm systems

@chensuyue
Copy link
Collaborator

Please add a similar CI test like this, so we can trigger the test on amd gpu, https://github.com/opea-project/GenAIExamples/blob/ee87d75876b231a0f290a69d7e21d21aad74a16a/DocSum/tests/test_compose_on_gaudi.sh

@chensuyue
Copy link
Collaborator

And the node from AMD is offline, please check the connect status,
image

@chensuyue chensuyue added the WIP label Nov 4, 2024
@astafevav astafevav marked this pull request as draft November 5, 2024 12:24
@astafevav astafevav marked this pull request as ready for review November 5, 2024 13:22
@astafevav astafevav force-pushed the add-docsum-rocm-docker-compose-example branch from 0e08891 to 7ea3fa8 Compare November 6, 2024 06:03
@astafevav
Copy link
Author

Hi @chensuyue, thank you for review,

I've added test scripts for AMD Rocm for DocSum And FaqGen,

But still clarifying status for coresite-sv7-106-amd-mi300-19 with the team.

@astafevav astafevav force-pushed the add-docsum-rocm-docker-compose-example branch from 7ea3fa8 to 713cc1b Compare November 6, 2024 12:41
@@ -0,0 +1,87 @@
# Copyright (C) 2024 Intel Corporation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add AMD copyright.

@@ -0,0 +1,184 @@
#!/bin/bash
# Copyright (C) 2024 Intel Corporation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here.

@chensuyue chensuyue modified the milestone: v1.1 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants