feat: updating to use latest ocm for certificates and adding gitea support validation #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skarlso
force-pushed
the
add-gitea-validation
branch
from
d5e563e
to
1802460
Compare
Skarlso
force-pushed
the
add-gitea-validation
branch
from
1802460
to
ceaa850
Compare
Skarlso
force-pushed
the
add-gitea-validation
branch
from
ceaa850
to
1041894
Compare
phoban01
approved these changes
Jul 18, 2023
souleb
reviewed
Jul 18, 2023
| } | ||
| } | ||
|
|
||
| func (v *Validator) FailValidation(ctx context.Context, repository gitv1alpha1.Repository, sync deliveryv1alpha1.Sync) error { |
There was a problem hiding this comment.
FailValidation and PassValidation mostly do the same thing. We could have a higher order function that provide the status.
There was a problem hiding this comment.
I like the distinguishing in the calling code. This could be a single function saying set status or something. But I like that we can call pass it or fail it; whatever the status is, the caller doesn't have to know. That's why I have these two.
Skarlso
force-pushed
the
add-gitea-validation
branch
from
9b1c437
to
615913c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.