Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner: run multiple versions of each solver #55

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jacek-oet
Copy link
Contributor

No description provided.

Copy link
Contributor

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank Jacek, it looks good overall, but I left some suggestions and requests. Also, let's make a separate PR to add a CI test for streamlit, especially if you switch from what you have here to something like https://docs.streamlit.io/develop/concepts/app-testing/automate-tests#running-the-app-tests

runner/run_benchmarks.py Outdated Show resolved Hide resolved
runner/run_benchmarks.py Outdated Show resolved Hide resolved
runner/run_benchmarks.py Show resolved Hide resolved
runner/requirements-2020.txt Outdated Show resolved Hide resolved
@jacek-oet jacek-oet marked this pull request as ready for review November 14, 2024 07:27
Copy link
Contributor

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jacek. A couple of more small things to be done before we can merge this. 🙏

All pages of the website other than the Solver History page should only use the data for the latest version of each solver

Did you do this already? If not, please implement that as well, thanks.

results/benchmark_results.csv Outdated Show resolved Hide resolved
runner/run_benchmarks.py Outdated Show resolved Hide resolved
runner/requirements-2022.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants