Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schemaChanges.sql(change "MD5" to "sha256"to postgres compatible) #18198

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update schemaChanges.sql(change "MD5" to "sha256"to postgres compatible) #18198

wants to merge 7 commits into from

Conversation

MugeshRajaR
Copy link

@MugeshRajaR MugeshRajaR commented Oct 9, 2024 •
edited
Loading

When i am trying to install the openmetadata, i have encountered with the below issue. "ERROR: could not compute MD5 hash: disabled for FIPS". The only option to change the "MD5" funtion to other compatible function like "AES-265" to prevent the error.

Please suggest if any other ways also there.

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@MugeshRajaR
Update schemaChanges.sql
9e22e7e 
When i am trying to install the openmetadata, i have encountered with the below issue. "ERROR: could not compute MD5 hash: disabled for FIPS". The only option to change the "MD5" funtion to other compatible function like "AES-265" to prevent the error.

Please suggest if any other ways also there.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@MugeshRajaR
Update schemaChanges.sql
c1e36cb 
Instead of putting AES-256 wrongly mentioned AES-265 earlier.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@MugeshRajaR
Update schemaChanges.sql
67d3539 
Felt like SHA256 is better option to replace with MD5 funtion over AES-256.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@MugeshRajaR MugeshRajaR changed the title Update schemaChanges.sql(change "MD5" to "AES-265"to postgres compatible) Update schemaChanges.sql(change "MD5" to "SHA-256"to postgres compatible) Oct 10, 2024
@MugeshRajaR
Update schemaChanges.sql
ded0a57 
Wrongly named the hashing method as SHA256 instead of SHA-256
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@MugeshRajaR
Update schemaChanges.sql
5aff040 
modified the hasing changes properly to use sha256
@MugeshRajaR MugeshRajaR changed the title Update schemaChanges.sql(change "MD5" to "SHA-256"to postgres compatible) Update schemaChanges.sql(change "MD5" to "sha256"to postgres compatible) Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

MugeshRajaR
MugeshRajaR commented Oct 10, 2024
View reviewed changes
Copy link
Author

@MugeshRajaR MugeshRajaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have a look and provide approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MugeshRajaR