Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow changing the default revisionHistoryLimit #2920

Merged
merged 2 commits into from
Aug 2, 2023
Merged

feat: allow changing the default revisionHistoryLimit #2920

merged 2 commits into from
Aug 2, 2023

Conversation

tberreis
Copy link
Contributor

@tberreis tberreis commented Aug 2, 2023

What this PR does / why we need it:
You may want to clean up old replica sets so that these don't appear in metrics, OPA violations, ArgoCD UI and so on.
Therefore you want to overwrite the Kubernetes default revision history limit.

See Kubernetes Clean up Policy.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
N/A

Special notes for your reviewer:

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (738b3e2) 53.15% compared to head (f549f7d) 53.13%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2920      +/-   ##
==========================================
- Coverage   53.15%   53.13%   -0.02%     
==========================================
  Files         135      135              
  Lines       11790    11790              
==========================================
- Hits         6267     6265       -2     
- Misses       5039     5041       +2     
  Partials      484      484              
Flag Coverage Δ
unittests 53.13% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sozercan sozercan merged commit db4f346 into open-policy-agent:master Aug 2, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants