Master 314 #185
Closed
Master 314 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement AssignImage mutator Signed-off-by: davis-haba <[email protected]> * fix tests Signed-off-by: davis-haba <[email protected]> * fix controller gen setup Signed-off-by: davis-haba <[email protected]> * fix helm manifest generation Signed-off-by: davis-haba <[email protected]> * WIP assignimage byPod status Signed-off-by: davis-haba <[email protected]> * mutator pod status working for assignimage Signed-off-by: davis-haba <[email protected]> * e2e test assignimage mutator deleted Signed-off-by: davis-haba <[email protected]> * old kubectl run Signed-off-by: davis-haba <[email protected]> * address comments. domain must have '.' unless localhost Signed-off-by: davis-haba <[email protected]> * appease linter Signed-off-by: davis-haba <[email protected]> * fix gator tests Signed-off-by: davis-haba <[email protected]> * add test domain ending in colon still converges Signed-off-by: davis-haba <[email protected]> * docs for assignimage Signed-off-by: davis-haba <[email protected]> * remove newline Signed-off-by: davis-haba <[email protected]> * address comments Signed-off-by: davis-haba <[email protected]> * appease linter Signed-off-by: davis-haba <[email protected]> * cleanup dead code branch Signed-off-by: davis-haba <[email protected]> * validateDomain to use splitDomain Signed-off-by: davis-haba <[email protected]> * future-proof validateImageParts. Add custom error types. Signed-off-by: davis-haba <[email protected]> * fix readiness tracker test Signed-off-by: davis-haba <[email protected]> * make manifests Signed-off-by: davis-haba <[email protected]> * validate that splitting a valid tag never returns a path Signed-off-by: davis-haba <[email protected]> * degenerate cases for unit tests. do not expose regex on image component error. Signed-off-by: davis-haba <[email protected]> * test missing image field. update error copy. Signed-off-by: davis-haba <[email protected]> * tag error copy Signed-off-by: davis-haba <[email protected]> * Update pkg/expansion/system_test.go Co-authored-by: Rita Zhang <[email protected]> Signed-off-by: Davis Haba <[email protected]> * Update pkg/mutation/mutators/assignimage/assignimage_mutator.go Co-authored-by: Rita Zhang <[email protected]> Signed-off-by: Davis Haba <[email protected]> * errors.As instead of type casting in unit tests Signed-off-by: davis-haba <[email protected]> * fix error type checking Signed-off-by: davis-haba <[email protected]> Signed-off-by: Davis Haba <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]> Co-authored-by: Rita Zhang <[email protected]>
…y-agent#2530) * Upgrade to k8s v0.26.1 and controller-runtime fork Signed-off-by: Max Smythe <[email protected]> * Re-add stop channel to informer map entry Signed-off-by: Max Smythe <[email protected]> * Update linter version Signed-off-by: Max Smythe <[email protected]> * Fix lint errors Signed-off-by: Max Smythe <[email protected]> * Fix broken tests Signed-off-by: Max Smythe <[email protected]> * Fix function docstring Signed-off-by: Max Smythe <[email protected]> * Fix gofumpt violation Signed-off-by: Max Smythe <[email protected]> Signed-off-by: Max Smythe <[email protected]>
…-agent#2536) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
…cy-agent#2535) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
…ent#2543) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…licy-agent#2547) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
open-policy-agent#2546) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add --operation=mutation-controller flag Signed-off-by: davis-haba <[email protected]> * operations in sorted order Signed-off-by: davis-haba <[email protected]> * update mutation-controller op docs to indicate audit may also need the flag Signed-off-by: davis-haba <[email protected]> --------- Co-authored-by: Sertaç Özercan <[email protected]>
…cy-agent#2545) Introduce gci to unify the order of package import Signed-off-by: Fish-pro <[email protected]> Co-authored-by: Rita Zhang <[email protected]>
…ted (since v1.49.0) (open-policy-agent#2550) Co-authored-by: Sertaç Özercan <[email protected]>
…ent#2564) removed unused kustomize step Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Zechun Chen <[email protected]>
Co-authored-by: Sertaç Özercan <[email protected]>
…nt#2581) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…licy-agent#2566) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#2565) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
open-policy-agent#2567) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#2568) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: Max Smythe <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: Max Smythe <[email protected]>
Signed-off-by: alex <[email protected]>
…n-policy-agent#2997) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
…olicy-agent#2996) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
…ent#3041) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
…#3060) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#3070) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…olicy-agent#3069) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]> Co-authored-by: JaydipGabani <[email protected]>
…agent#3076) Signed-off-by: Sertac Ozercan <[email protected]>
…cy-agent#3086) Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]> Co-authored-by: sozercan <[email protected]>
…ck for 3.14 (open-policy-agent#3141) Signed-off-by: Alex Pana <[email protected]> Signed-off-by: alex <[email protected]> Signed-off-by: Sertaç Özercan <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: GitHub <[email protected]> Co-authored-by: sozercan <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: Yi Rae Kim <[email protected]>
Signed-off-by: mprahl <[email protected]> Co-authored-by: mprahl <[email protected]> Signed-off-by: Yi Rae Kim <[email protected]>
ref: https://issues.redhat.com/browse/ACM-6233 Signed-off-by: Dale Haiducek <[email protected]> Co-authored-by: Dale Haiducek <[email protected]> Signed-off-by: Yi Rae Kim <[email protected]>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: