-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audit deployment label #1060
Fix audit deployment label #1060
Conversation
Signed-off-by: Sertac Ozercan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1060 +/- ##
==========================================
+ Coverage 47.87% 47.94% +0.07%
==========================================
Files 62 62
Lines 4267 4267
==========================================
+ Hits 2043 2046 +3
+ Misses 1967 1965 -2
+ Partials 257 256 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Should we remove these labels entirely? They are vistigial from Kubebuilder 1.0 days. I suppose some users may have created dependencies on these labels? If so, we should probably make sure we warn them of a potentially breaking change to their setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
some thoughts on whether these labels are useful and on backwards compatibility
Opened #1061 for tracking deprecation |
Signed-off-by: Sertac Ozercan [email protected]
What this PR does / why we need it:
Audit deployment label should be
audit-controller
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: