Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert inaccessible test to error specific #3205

Closed
wants to merge 1 commit into from
Closed

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Jan 2, 2024

convert the inaccessible ErrOldObjectIsNil test to an error specific test

@apeabody apeabody requested a review from a team as a code owner January 2, 2024 20:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6503979) 53.70% compared to head (a12a220) 53.86%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3205      +/-   ##
==========================================
+ Coverage   53.70%   53.86%   +0.15%     
==========================================
  Files         136      136              
  Lines       12198    12198              
==========================================
+ Hits         6551     6570      +19     
+ Misses       5143     5128      -15     
+ Partials      504      500       -4     
Flag Coverage Δ
unittests 53.86% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apeabody apeabody requested a review from acpana January 2, 2024 20:28
@apeabody
Copy link
Contributor Author

apeabody commented Jan 2, 2024

merge into #3206

@apeabody apeabody closed this Jan 2, 2024
@sozercan sozercan deleted the ap-fds2 branch February 28, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants