Skip to content

Commit

Permalink
update readme informations about zenoh version
Browse files Browse the repository at this point in the history
Signed-off-by: thomasung <[email protected]>

clean dangling code
  • Loading branch information
tomkimsour committed Oct 16, 2024
1 parent f3920bd commit 0c8311d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Supports
* [ROS 2 Jazzy](https://docs.ros.org/en/jazzy/index.html)
* [rmw-cyclonedds-cpp](https://github.com/ros2/rmw_cyclonedds)
* [Open-RMF on main](https://github.com/open-rmf/rmf)
* [zenoh-bridge-ros2dds v0.11](https://github.com/eclipse-zenoh/zenoh-plugin-ros2dds/releases/tag/0.11.0)
* [zenoh-bridge-ros2dds v1.0.0-beta.4](https://github.com/eclipse-zenoh/zenoh-plugin-ros2dds/releases/tag/1.0.0-beta.4)

We recommend setting up `zenoh-bridge-ros2dds` with the standalone binaries. After downloading the appropriate released version and platform, extract and use the standalone binaries as is. For source builds of `zenoh-bridge-ros2dds`, please follow the [official guides](https://github.com/eclipse-zenoh/zenoh-plugin-ros2dds).

Expand All @@ -43,7 +43,7 @@ sudo apt install python3-pip ros-jazzy-rmw-cyclonedds-cpp
The dependencies `eclipse-zenoh` and `pycdr2` are available through `pip`. Users can choose to set up a virtual environment, or `--break-system-packages` by performing the installation directly.

```bash
pip3 install eclipse-zenoh==0.11.0 pycdr2 --break-system-packages
pip3 install pip install eclipse-zenoh==1.0.0b4 pycdr2 --break-system-packages
```

> [!NOTE]
Expand Down Expand Up @@ -256,7 +256,6 @@ ros2 run rmf_demos_tasks dispatch_patrol \
* attempt to optimize tf messages (not all are needed)
* ROS 1 nav support
* map switching support
* update to use zenoh 1.0
* static testing
* end-to-end testing
* support for Rolling
Expand Down
3 changes: 1 addition & 2 deletions free_fleet_adapter/free_fleet_adapter/nav2_robot_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,12 @@ def navigate(self, destination, execution):
behavior_tree=""
)

print("about to get the action")
replies = self.zenoh_session.get(
namespace_topic("navigate_to_pose/_action/send_goal", self.name),
payload=req.serialize(),
# timeout=0.5
)
print("finished to get the action")

for reply in replies:
try:
rep = NavigateToPose_SendGoal_Response.deserialize(
Expand Down
4 changes: 0 additions & 4 deletions free_fleet_adapter/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@
os.path.join("share", package_name, "launch"),
glob("launch/*.launch.xml"),
),
(
os.path.join("share", package_name, "fleet_configs"),
glob("fleet_configs/*.yaml"),
),
],
install_requires=["setuptools"],
zip_safe=True,
Expand Down

0 comments on commit 0c8311d

Please sign in to comment.