Use a single module for all binaries #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
chore/single-module
branch
from
6f6dddd
to
6ef4a87
Compare
swiatekm
force-pushed
the
chore/single-module
branch
from
5138b6b
to
a860e33
Compare
swiatekm
force-pushed
the
chore/single-module
branch
4 times, most recently
from
42517a8
to
b118d0f
Compare
pavolloffay
approved these changes
Jan 11, 2024
swiatekm
force-pushed
the
chore/single-module
branch
from
b118d0f
to
16cc930
Compare
jaronoff97
approved these changes
Jan 11, 2024
|
this LGTM. were you able to build the docker containers locally and they worked totally fine? I don't think there would be any problems, but just for extra safety. |
I have. And e2e tests do this anyway, so we would've seen some breakage there. |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Use a single module for all binaries * Move Go setup after checkout in CI jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single Go module for all binaries. This simplifies our project structure and tooling. Benefits include:
The only downside is that dependencies cannot be different between the components, but even that's partially a benefit.