Add test for adding new collector after completed initial allocation #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation (#1) * Rename target creator helper function * Add test for adding new collector
jaronoff97
approved these changes
Dec 22, 2023
|
I think this simple PR does not require any addition to change log. Could we add the |
swiatekm
reviewed
Jan 2, 2024
swiatekm
approved these changes
Jan 2, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…pen-telemetry#2478) * Implement test for adding new collector after completed initial allocation (open-telemetry#1) * Rename target creator helper function * Add test for adding new collector * Add dot to test comment to fix lint * Revert target creator helper function * Remove unused collector label to avoid confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As mentioned in the linked issue, the
least-weightedallocation strategy is at the moment not capable of scaling out. Shortly explained, after the targets are distributed across the initial set of collector instances, the newly added collector instance will not be assigned any targets.This added test ensures that the current capability is covered. In case it will be decided in the future to change the implementation in order to achieve scaling capability, this test will fail and will thereby signal for a new test to be created.
Link to tracking Issue:
2477
Testing:
The test
allocation/TestNoAssignmentToNewCollectoris added.Documentation:
The test assures that the newly added collectors are not assigned any targets after a successful target distribution across the initially detected collectors.