Embed the struct in v1alpha2 #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
commented
Jan 11, 2024
| @@ -18521,6 +18521,13 @@ TargetAllocator indicates a value which determines whether to spawn a target all | |||
| PodDisruptionBudget specifies the pod disruption budget configuration to use for the target allocator workload.<br/> | |||
| </td> | |||
| <td>false</td> | |||
| </tr><tr> | |||
| <td><b><a href="#opentelemetrycollectorspectargetallocatorpodsecuritycontext">podSecurityContext</a></b></td> | |||
There was a problem hiding this comment.
this was because we embed the v1 target allocator struct :/
pavolloffay
approved these changes
Jan 12, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Embeds the struct instead of using composition