Add support for merging GO* variables when existing ones are present in the manifest. #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
frzifus
reviewed
Oct 18, 2024
| ContainerName: naming.Container(), | ||
| skipGoMemLimit, skipGoMaxprocs := false, false | ||
| for _, v := range envVars { | ||
| if v.Name == "GOMEMLIMIT" { |
There was a problem hiding this comment.
What does happen when the golangFlags fg is enabled and the env variable is set in the CR?
|
I think I'd rather solve this in a more generic way. That is, ensure that we don't set any env variables the user has set. You can run into the same issue as this PR tries to address if you try to set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default GOMEMLIMIT is set to 100pc which might not work with custom extensions/contrib collector which reccomends a 80pc. This allows users to set a custom value in the manifest and still not have duplicates.