-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Test OpenTelemetry must-gather script #3387
base: main
Are you sure you want to change the base?
Conversation
cc @iblancasa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this makes sense, but i'm wondering if we can try going one step further and checking that we get the expected metrics from the must gather? (i'm working on this in #3381 and would love us to do more of this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, had some relatively minor comments.
#!/bin/bash | ||
|
||
# Create the directory to store must-gather | ||
MUST_GATHER_DIR=/tmp/must-gather |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use mktemp -d
here instead of a fixed directory? I know we delete it at the end, but I'd like to minimize potential conflicts.
template: true | ||
file: install-target-allocator.yaml | ||
- assert: | ||
file: install-target-allocator-assert.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is an assertion file, can we name it assert-target-allocator.yaml
instead? It's easier to see at a glance what each yaml file represents if it's in the prefix.
catch: | ||
- podLogs: | ||
selector: app.kubernetes.io/component=opentelemetry-targetallocator | ||
- name: assert-data-propagates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we asserting this separately here, as opposed to putting it in install-target-allocator-assert.yaml
?
- apply: | ||
file: install-app.yaml | ||
- assert: | ||
file: install-app-assert.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, I'd prefer assert-app-installed.yaml
.
name: ta | ||
namespace: ($namespace) | ||
--- | ||
apiVersion: opentelemetry.io/v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we start using v1beta1
?
Description:
The PR adds tests for OpenTelemetry Operator must-gather script, which collects troubleshooting data from the operator and CR instances.