[Chore] Test OpenTelemetry must-gather script #3387
Conversation
|
cc @iblancasa |
There was a problem hiding this comment.
i think this makes sense, but i'm wondering if we can try going one step further and checking that we get the expected metrics from the must gather? (i'm working on this in #3381 and would love us to do more of this)
| #!/bin/bash | ||
|
|
||
| # Create the directory to store must-gather | ||
| MUST_GATHER_DIR=/tmp/must-gather |
There was a problem hiding this comment.
Can we use mktemp -d here instead of a fixed directory? I know we delete it at the end, but I'd like to minimize potential conflicts.
| template: true | ||
| file: install-target-allocator.yaml | ||
| - assert: | ||
| file: install-target-allocator-assert.yaml |
There was a problem hiding this comment.
If this is an assertion file, can we name it assert-target-allocator.yaml instead? It's easier to see at a glance what each yaml file represents if it's in the prefix.
| catch: | ||
| - podLogs: | ||
| selector: app.kubernetes.io/component=opentelemetry-targetallocator | ||
| - name: assert-data-propagates |
There was a problem hiding this comment.
Why are we asserting this separately here, as opposed to putting it in install-target-allocator-assert.yaml?
| - apply: | ||
| file: install-app.yaml | ||
| - assert: | ||
| file: install-app-assert.yaml |
There was a problem hiding this comment.
Same as above, I'd prefer assert-app-installed.yaml.
| name: ta | ||
| namespace: ($namespace) | ||
| --- | ||
| apiVersion: opentelemetry.io/v1alpha1 |
There was a problem hiding this comment.
could we start using v1beta1 ?
Description:
The PR adds tests for OpenTelemetry Operator must-gather script, which collects troubleshooting data from the operator and CR instances.