Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SemConv to 1.25.0 #1271

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

CRC-Mismatch
Copy link
Contributor

@CRC-Mismatch CRC-Mismatch commented Apr 5, 2024

I'm not sure if there's a workflow for this, but I noticed that there are some missing constants that (I'd like to use and) are already documented at https://opentelemetry.io/docs/specs/semconv/, so I thought I should try to help out... 🤷‍♂️

I only refreshed my local repo and ran make install, updated the versions in the script, ran make semconv and then make all (and all seemed fine) - don't know if that's all or if I should do something else.

@CRC-Mismatch CRC-Mismatch requested a review from a team April 5, 2024 20:22
Copy link

welcome bot commented Apr 5, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

Copy link

linux-foundation-easycla bot commented Apr 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@CRC-Mismatch
Copy link
Contributor Author

CRC-Mismatch commented Apr 5, 2024

Sorry about the force-pushes, I had originally commited using a corporate email instead of my personal one by mistake...

@brettmc
Copy link
Collaborator

brettmc commented Apr 7, 2024

don't know if that's all or if I should do something else

We've had issues in the past where entries have been deleted upstream, which has broken bits of our code that refer to them. semconv has been getting better in that regard, but I always check (there's some code and instructions in script/semantic-conventions/README.md)

@CRC-Mismatch
Copy link
Contributor Author

CRC-Mismatch commented Apr 8, 2024

but I always check (there's some code and instructions in script/semantic-conventions/README.md)

Not sure if I did it right, but both commands gave me empty outputs... I guess that means there were no removed consts, but since "it's my first time here", I'm just mentioning it to be safe...

@brettmc brettmc merged commit fda522a into open-telemetry:main Apr 9, 2024
9 checks passed
@CRC-Mismatch
Copy link
Contributor Author

@brettmc any ETA on the release?

@brettmc
Copy link
Collaborator

brettmc commented Apr 18, 2024

any ETA on the release?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants