Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextMapPropagator to instrumentation context #1401

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Oct 13, 2024

Necessary for HTTP instrumentations etc.

@Nevay Nevay requested a review from a team as a code owner October 13, 2024 15:47
Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for opentelemetry-php canceled.

Name Link
🔨 Latest commit 28a91dc
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-php/deploys/670bebaaf536fc000812b4bc

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 73.69%. Comparing base (cd8c0e3) to head (28a91dc).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...c/SDK/Propagation/LateBindingTextMapPropagator.php 0.00% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1401      +/-   ##
============================================
- Coverage     73.85%   73.69%   -0.17%     
- Complexity     2672     2680       +8     
============================================
  Files           386      387       +1     
  Lines          7650     7668      +18     
============================================
+ Hits           5650     5651       +1     
- Misses         2000     2017      +17     
Flag Coverage Δ
8.1 73.33% <38.09%> (-0.18%) ⬇️
8.2 73.56% <38.09%> (-0.26%) ⬇️
8.3 73.60% <38.09%> (-0.05%) ⬇️
8.4 73.57% <38.09%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...PI/Instrumentation/AutoInstrumentation/Context.php 100.00% <ø> (ø)
src/SDK/SdkAutoloader.php 93.91% <100.00%> (+0.39%) ⬆️
...c/SDK/Propagation/LateBindingTextMapPropagator.php 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8c0e3...28a91dc. Read the comment docs.

@brettmc brettmc merged commit 2c1da9a into open-telemetry:main Oct 15, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants