Adding ruff rule A
#4232
Open
Adding ruff rule A
#4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Oct 22, 2024
docs/conf.py
Outdated
| @@ -47,7 +47,7 @@ | |||
| # -- Project information ----------------------------------------------------- | |||
|
|
|||
| project = "OpenTelemetry Python" | |||
| copyright = "OpenTelemetry Authors" # pylint: disable=redefined-builtin | |||
| docs_copyright = "OpenTelemetry Authors" # pylint: disable=redefined-builtin | |||
There was a problem hiding this comment.
I am pretty sure we cannot change sphinx configuration for pleasing some lint rules 😅 see
https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-copyright
| @@ -121,8 +121,8 @@ def _is_valid_value(value: object) -> bool: | |||
| parts = str(value).split(";") | |||
| is_valid_value = _VALUE_PATTERN.fullmatch(parts[0]) is not None | |||
| if len(parts) > 1: # one or more properties metadata | |||
| for property in parts[1:]: | |||
| if _PROPERT_PATTERN.fullmatch(property) is None: | |||
| for properties in parts[1:]: | |||
There was a problem hiding this comment.
Maybe prop instead since this looks like is one property?
There was a problem hiding this comment.
prop, properties or no change?
| @@ -684,7 +684,7 @@ def start_span( | |||
| context = SpanContextShim(span.get_span_context()) | |||
| return SpanShim(self, context, span) | |||
|
|
|||
| def inject(self, span_context, format: object, carrier: object): | |||
| def inject(self, span_context, formats: object, carrier: object): | |||
There was a problem hiding this comment.
Not sure we can rename function parameters because a linter rule does not like it :)
There was a problem hiding this comment.
Yes, in this case, I think we can just ignore it.
|
Maybe I'll just revert back all changes and just stick to adding rules. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address part of #4227
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Aaffects variable, argument, import, module names.)Does This PR Require a Contrib Repo Change?
Checklist: