Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(zipkin-exporter): simplify success status check and add test for 204 response #4339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slyapustin
Copy link

… for 204 response

Description

Simplify success status check and add test for 204 response

Fixes #4338

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@slyapustin slyapustin requested a review from a team as a code owner December 5, 2024 15:46
Copy link

linux-foundation-easycla bot commented Dec 5, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@codefromthecrypt
Copy link
Contributor

made this comment on the originating issue as the zipkin api is stable, and doing something like this would end up a similar ask on all language repos maybe. It could be easier to identify which server is using the wrong status code and ask them to switch to 202 #4338 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response success status validated incorrectly
2 participants