process.executable.build_id: rename attribute #1520
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Lehner <[email protected]>
florianl
force-pushed
the
profiling-htlhash
branch
3 times, most recently
from
7d85188
to
40e4902
Compare
florianl
force-pushed
the
profiling-htlhash
branch
from
40e4902
to
b9e6268
Compare
felixge
approved these changes
Oct 28, 2024
christos68k
approved these changes
Oct 28, 2024
| @@ -75,6 +75,7 @@ Deprecated process attributes. | |||
| | Attribute | Type | Description | Examples | Stability | | |||
| |---|---|---|---|---| | |||
| | <a id="process-cpu-state" href="#process-cpu-state">`process.cpu.state`</a> | string | Deprecated, use `cpu.mode` instead. | `system`; `user`; `wait` | <br>Replaced by `cpu.mode` | | |||
| | <a id="process-executable-build-id-profiling" href="#process-executable-build-id-profiling">`process.executable.build_id.profiling`</a> | string | "Deprecated, use `process.executable.build_id.htlhash` instead." | | <br>Replaced by `process.executable.build_id.htlhash` | | |||
There was a problem hiding this comment.
Since AFAIK we haven't released a profiling protocol version that includes build_id.profiling which means that we shouldn't be breaking anyone other than ourselves, maybe we shouldn't list it as deprecated to avoid carrying unnecessary baggage forward, if that's OK with other semconv maintainers and approvers.
There was a problem hiding this comment.
Other attributes, that got renamed and are marked as experimental, also require this approach - e.g. #1422
maybe @open-telemetry/specs-semconv-maintainers can provide more feedback and guidance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With open-telemetry/opentelemetry-specification#4197 it was decided to rename the attribute from
process.executable.build_id.profilingtoprocess.executable.build_id.htlhash(Head-Tail-Length Hash).FYI @open-telemetry/profiling-maintainers
Merge requirement checklist
[chore]