-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process.executable.build_id: rename attribute #1520
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Florian Lehner <[email protected]>
7d85188
to
40e4902
Compare
40e4902
to
b9e6268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is this level of change tracking needed while we're still experimental?
@@ -75,6 +75,7 @@ Deprecated process attributes. | |||
| Attribute | Type | Description | Examples | Stability | | |||
|---|---|---|---|---| | |||
| <a id="process-cpu-state" href="#process-cpu-state">`process.cpu.state`</a> | string | Deprecated, use `cpu.mode` instead. | `system`; `user`; `wait` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `cpu.mode` | | |||
| <a id="process-executable-build-id-profiling" href="#process-executable-build-id-profiling">`process.executable.build_id.profiling`</a> | string | "Deprecated, use `process.executable.build_id.htlhash` instead." | | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `process.executable.build_id.htlhash` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since AFAIK we haven't released a profiling protocol version that includes build_id.profiling
which means that we shouldn't be breaking anyone other than ourselves, maybe we shouldn't list it as deprecated to avoid carrying unnecessary baggage forward, if that's OK with other semconv maintainers and approvers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other attributes, that got renamed and are marked as experimental
, also require this approach - e.g. #1422
maybe @open-telemetry/specs-semconv-maintainers can provide more feedback and guidance
Changes
With open-telemetry/opentelemetry-specification#4197 it was decided to rename the attribute from
process.executable.build_id.profiling
toprocess.executable.build_id.htlhash
(Head-Tail-Length Hash).FYI @open-telemetry/profiling-maintainers
Merge requirement checklist
[chore]