get delegation working again but dangerously

open-toast · Jun 9, 2024 · d4b445f · d4b445f
1 parent 159dc33
commit d4b445f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/protokt-codegen/src/main/kotlin/protokt/v1/codegen/generate/Implements.kt b/protokt-codegen/src/main/kotlin/protokt/v1/codegen/generate/Implements.kt
@@ -16,6 +16,7 @@
 package protokt.v1.codegen.generate
 
 import com.squareup.kotlinpoet.ClassName
+import com.squareup.kotlinpoet.CodeBlock
 import com.squareup.kotlinpoet.TypeSpec
 import protokt.v1.codegen.generate.CodeGenerator.Context
 import protokt.v1.codegen.util.Message
@@ -47,7 +48,7 @@ internal object Implements {
                 if (msg.options.protokt.implements.delegates()) {
                     addSuperinterface(
                         ClassName.bestGuess(msg.options.protokt.implements.substringBefore(" by ")),
-                        msg.options.protokt.implements.substringAfter(" by ")
+                        CodeBlock.of(msg.options.protokt.implements.substringAfter(" by ") + "!!")
                     )
                 } else {
                     addSuperinterface(msg.superInterface(ctx)!!)

diff --git a/testing/options/src/main/proto/protokt/v1/testing/message_implements.proto b/testing/options/src/main/proto/protokt/v1/testing/message_implements.proto
@@ -36,7 +36,7 @@ message ImplementsModel2 {
 }
 
 message ImplementsWithDelegate {
-  // option (.protokt.v1.class).implements = "IModel2 by modelTwo!!";
+  option (.protokt.v1.class).implements = "IModel2 by modelTwo";
 
   ImplementsModel2 model_two = 1;
 }
diff --git a/testing/options/src/test/kotlin/protokt/v1/testing/MessageImplementsTest.kt b/testing/options/src/test/kotlin/protokt/v1/testing/MessageImplementsTest.kt
@@ -38,8 +38,8 @@ class MessageImplementsTest {
 
     @Test
     fun `message implementing by a delegate can be assigned to its interface`() {
-        // val byDelegate: IModel2 = ImplementsWithDelegate { modelTwo = model2 }
+        val byDelegate: IModel2 = ImplementsWithDelegate { modelTwo = model2 }
 
-        // assertThat(byDelegate.id).isEqualTo(model2.id)
+        assertThat(byDelegate.id).isEqualTo(model2.id)
     }
 }