-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed restructuring of file structure #29
Comments
@erikfilias @sandrinecharousset any comments? |
This does make sense from our model's point of view, and we do not see a problem in handling the extra yaml files. As capacities of Possible variable combination could then be:
|
I agree because internally I made a similar process to convert data format. I only have a doubt related to the validation process. |
I also agree with your proposal @danielhuppmann |
But I am not completely sure that all kinds of power plant would have the same 'strucure' of 'characteristics'; eg hydro plants are very different.... We usually have 4 different kinds: 1/ thermal plants (including coal, gas, nuclear, biomasse ...) 2/ hydro reservoir plants 3/ other renewable plants with variable capacity (including PV, wind, runofriver) - Those different kinds of plants share some characteristics (like Maximum Active power....) but some characteristics are only for some of the plants (like volumes...) |
The list of variables is already becoming quite long, causing a risk of confusion or duplication going forward. One option is to separate the definitions into two parts at least for those variables.
Using the following example
Capacity|Electricity|Coal|w/ CCS
Capacity|Electricity
Coal|w/ CCS
This could then be defined in two separate files and linked by defining the variable as:
Capacity|Electricity|<Power Plants>
and a list of power plants types.
The advantage is that it would result in shorter files. The disadvantage is that it makes reading the yaml files more complicated (because a user would have to switch back and forth), and it would require a more sophisticated programmatic implementation (e.g., a Python package) to use the definitions in automated workflows.
The text was updated successfully, but these errors were encountered: