Nomad Restart and Reschedule Policy #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpass99
commented
Jun 12, 2024
mpass99
commented
Jun 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
+ Coverage 76.92% 76.98% +0.05%
==========================================
Files 41 41
Lines 3498 3498
==========================================
+ Hits 2691 2693 +2
+ Misses 592 590 -2
Partials 215 215 ☔ View full report in Codecov by Sentry. |
mpass99
force-pushed
the
fix/#587-restart-policy
branch
from
0964910 to
7b9cd3f
Compare
MrSerth
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Thanks!
I would not add an e2e for this scenario. We would mainly test Nomad (and not something truly Poseidon specific), which doesn't feel right. Further the long increase is really not ideal. If at all, I would opt to add another template job with shorter wait times specifically for the given scenario. Still, I don't think it's the right thing to do...
because our current Poseidon-Nomad architecture has a 1:1 runner-job relationship and there is no need to have more than the one task per job.
to limit the number of reschedules as we cannot guarantee an error-free job definition. We also set reasonable delays and intervals to increase the likelihood that one deployment has enough time, but there is no second deployment within the interval.
MrSerth
force-pushed
the
fix/#587-restart-policy
branch
from
7b9cd3f to
2dd0d16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #587
Fix restart and reschedule configuration to not reschedule infinitely (e.g. due to an invalid image specifier).
ToDo:
Should we write an e2e test checking that a wrong environment definition does not loop infinitely? With the current configuration, the test will last almost 10 minutes..No