Fix MR Reads (ADIOS) #332
Merged
Fix MR Reads (ADIOS) #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
fix-mr-undefinedRegions
branch
2 times, most recently
from
c62fe8c
to
f6b52ed
Compare
Start to fix MR reads on higher levels, where we have declared but undefined regions and need to filter by valid boxes.
ax3l
force-pushed
the
fix-mr-undefinedRegions
branch
from
f6b52ed
to
b8b5a48
Compare
ax3l
commented
Feb 17, 2022
openpmd_viewer/openpmd_timeseries/data_reader/io_reader/utilities.py
Outdated
Show resolved
Hide resolved
ax3l
commented
Feb 17, 2022
ax3l
force-pushed
the
fix-mr-undefinedRegions
branch
2 times, most recently
from
a6993a9
to
bd62e71
Compare
ax3l
commented
Feb 17, 2022
| @@ -38,12 +38,12 @@ def run_tests(self): | |||
| tests_require=['pytest', 'jupyter'], | |||
| install_requires=install_requires, | |||
| extras_require = { | |||
| 'all': ["ipympl", "ipywidgets", "matplotlib", "numba", "openpmd-api", "wget"], | |||
| 'all': ["ipympl", "ipywidgets", "matplotlib", "numba", "openpmd-api~=0.14.0", "wget"], | |||
There was a problem hiding this comment.
With 0.14.0+, available_chunks/availableChunks became mature enough to be used in all use cases:
https://github.com/openPMD/openPMD-api/blob/0.14.4/CHANGELOG.rst
ax3l
force-pushed
the
fix-mr-undefinedRegions
branch
6 times, most recently
from
f20dcbd
to
9703458
Compare
|
cc @tmsclark and @lucafedeli88 for review :) |
ax3l
force-pushed
the
fix-mr-undefinedRegions
branch
from
9703458
to
e2217e2
Compare
RemiLehe
approved these changes
Feb 24, 2022
This was referenced Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to fix MR reads on higher levels, where we have declared but undefined regions and need to filter by valid boxes.
Old Implementation
Full read included UB regions that should not be read (standard: openPMD/openPMD-standard#252).
After multiple reads, this could look like this:
New Implementation
Mask invalid regions to zero, read only valid regions:
