This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
graceful and forced failover: better anlaysis including GTID fix #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomi-noach
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #508
While this PR was originated to fix #508, it actually fixes more than that.
With
graceful-master-takeoverandforce-master-failover, we impose a failover scenario onorchestratoreven though it may not recognize one (indeed, in agracefulscenario there is no failure per se).The analysis in those two scenarios was imposed on
orchestrator. But as such, it lacked context and extra info. Namely, the one described in #508: lack of GTID context. Possibly also #421 is related.With this PR we force the full analysis on the master on both these operations, and get the full context, including GTID state of the replicas.
cc @almeida-pythian @ManjotS