Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usbmux: make fetch Python 3.7 compatible #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

usbmux: make fetch Python 3.7 compatible #153

wants to merge 1 commit into from

Conversation

StephenGemin
Copy link

@StephenGemin StephenGemin commented Jul 22, 2024 •
edited
Loading

Tested

  • iOS16 and 17
  • python 3.7 and 3.9

Launched WDA app separately

export DEVICE_URL="http://192.168.2.58:8100"
pytest -k test_client_status tests

Also modified two tests locally

  • test_element_scroll_visible - removed pytest.skip decorator
  • test_element_name_matches - changed mandarin to english "蓝牙" -> "Bluetooth"

@StephenGemin StephenGemin marked this pull request as ready for review July 22, 2024 21:21
@StephenGemin StephenGemin force-pushed the usbmux/fetch_py37_compatible branch 2 times, most recently from 6a29859 to 8db4a99 Compare July 22, 2024 22:08
@StephenGemin
Copy link
Author

@codeskyblue , pinging for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StephenGemin