Find the reason why #234 does not work and fix it

openbiox · Dec 13, 2021 · 8dd4484 · 8dd4484
1 parent 2830186
commit 8dd4484
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,6 @@
 # UCSCXenaShiny 1.1.4
 
+- Fixed the colnames being changed by `as.data.frame()` when querying a symbol with unvalid R name. (Related to #234)
 - Added more informative error for scatter plot in General Analysis tab. (#233)
 - Reversed default color setting for groups in survival analysis to fit conventional color grouping (in Xena).
 (#232, thanks to feedback from [Enrique](https://github.com/quiquemedina))

diff --git a/R/query_value.R b/R/query_value.R
@@ -34,6 +34,7 @@ query_molecule_value <- function(dataset, molecule, host = NULL) {
       {
         values <- purrr::map(ids, ~ get_data(dataset, ., host = host))
         df <- as.data.frame(values %>% purrr::set_names(ids))
+        colnames(df) <- ids
         sig_values <- eval(fm, envir = df)
         names(sig_values) <- rownames(df)
         0L
@@ -116,6 +117,7 @@ query_pancan_value <- function(molecule,
         } else {
           df <- as.data.frame(purrr::map(values, ~ .[[1]]) %>% purrr::set_names(ids))
         }
+        colnames(df) <- ids
         sig_values <- eval(fm, envir = df)
         names(sig_values) <- rownames(df)
         0L