Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature-external-dicts #578

Open
wants to merge 1 commit into
base: feature-external-dicts
Choose a base branch
from

Conversation

Helium314
Copy link
Contributor

There were some problems getting dictionaries to the correct folder, and some issues with mixed- and lower case locales strings.

Also "categories" for dictionaries can now be separated by _, which allows for proper detection and usage of additional dictionaries (e.g. for emojis) as long as the category is unique.
Looks like categories are not used for anything except detecting main category to decide whether to load built-in main dictionary.

@julianfairfax
Copy link

Why has this PR been open for a year, and why has external dicts support not been merged into the main app? We shouldn't have to use https://github.com/Helium314/openboard/releases for this feature.

Helium314 added a commit to Helium314/HeliBoard that referenced this pull request Jun 26, 2023
openboard-team/openboard#569
openboard-team/openboard#578
modified so dictionaries use the correct type instead of always main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants