Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API tidy #523

Closed
wants to merge 31 commits into from
Closed

API tidy #523

wants to merge 31 commits into from

Conversation

julie-sullivan
Copy link
Contributor

See #522

  • API end points work as expected
  • No end point was prematurely "optimised"

@julie-sullivan julie-sullivan self-assigned this Jan 22, 2020
@julie-sullivan julie-sullivan changed the base branch from develop to next January 22, 2020 11:30
@imedina imedina added this to the v5.0.0 milestone Jan 27, 2020
@imedina imedina added the REST label Jan 27, 2020
@julie-sullivan
don't use run (yet) as we don't have jobs. checkstyle #522
b8a580b
@julie-sullivan
replace text in gene end point with constants. remove output format. #…
8ce23ae 
…522
@julie-sullivan
parse extra params, e.g. excludes, sort if needed. replace more text …
4a2a1b5 
…with constants. #522
@julie-sullivan
more replacements #522
44de29b
@julie-sullivan
more replacements, fix data type #522
23a707b
@julie-sullivan
organise constants by type, more replacements #522
fea25fa
@julie-sullivan
add count and sort to tfbs. #522
e51302b
@julie-sullivan
add sort and limit to transcript and region end points. #522
3a035dd
@julie-sullivan
add more options for xrefs #522
109b9b0
@julie-sullivan
add exclude,include for consistency. more text replacements. #522
bae0083
@julie-sullivan
add exclude,include for consistency. more text replacements. #522
547871f
@julie-sullivan
add exclude,include for consistency. more text replacements. #522
f3a672d
@julie-sullivan
more text replacements #522
82afad0
@julie-sullivan
checkstyle
053c8fa
@julie-sullivan
rename to groupby, move path for distinct endpoint so it better match…
ebea718 
…es the standard pattern. remove merge param. change pathparam geneId to be genes. rename snp to be variant. #522
@julie-sullivan
change to Boolean. the query is looking for a Boolean or String but N…
f71d1ca 
…OT a boolean. #522
@julie-sullivan
Copy link
Contributor Author

this pull request requires the latest updates to java-commons-lib

@imedina imedina closed this Apr 15, 2020
@imedina imedina deleted the issue-522-api-tidy branch April 15, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javild javild Awaiting requested review from javild

Assignees

@julie-sullivan julie-sullivan

Labels
REST
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@julie-sullivan @imedina