Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 483 #495

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Issue 483 #495

merged 2 commits into from
Apr 19, 2022

Conversation

antonioaltamura
Copy link
Contributor

This PR restores generateKey in opencga-parent-class.js and rest-client.js to avoid requests overlap and race-condition-related issues.
This also changes file-preview.js adding concurrent:true param to all file preview requests.

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
10.7% 10.7% Duplication

@pamag pamag linked an issue Apr 16, 2022 that may be closed by this pull request
Restore generateKey() in opencga-parent-class #483
Open
imedina
imedina approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@imedina imedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this because of lack of time, this will change in the next release

@imedina imedina merged commit 6f4acf1 into opencb:release-2.2.x Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imedina imedina imedina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore generateKey() in opencga-parent-class
2 participants
@antonioaltamura @imedina