Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Add Joint Model #102

Closed
wants to merge 198 commits into from
Closed

Add Joint Model #102

wants to merge 198 commits into from

Conversation

jacobbieker
Copy link
Member

@jacobbieker jacobbieker commented Oct 6, 2021

Pull Request

Description

This adds the ability to train a joint model that takes in multiple modalities and outputs both GSP and, optionally, satellite imagery.

This also splits out the dataloader to nowcasting-dataloader and adds support for the various positional encodings that that repo can make from openclimatefix/nowcasting_dataloader#2 and openclimatefix/nowcasting_dataloader#6

Things to do left in this PR:

  • Make it not require Double for all input types
  • Make the calculation of the input dim more flexible
  • Make the linear layer for the GSP post processing more flexible
  • Test outputting HRV and non-HRV Satellite imagery

Fixes #101

How Has This Been Tested?

Unit tests

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jacobbieker jacobbieker added the enhancement New feature or request label Oct 6, 2021
@jacobbieker jacobbieker self-assigned this Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Joint Model
3 participants