This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Add support for Nowcasting Dataset and Nowcasting Utils #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to remove the actual code dependent on it
Ties SatFlow quite tightly to nowcasting_utils, but it would be anyway
Data tests will mostly happen in nowcasting_dataset instead, so don't need these large files here
Nowcasting dataset covers it all, and gets rid of the need for many of these. SatFlowDataModule will be updated to use the NetCDFDataset and add any needed transforms in that or in a new datasets.py
Copy in predict_py_yield datamodule to customize for SatFlow
…ng_dataset Also remove visualization stubs as that will be covered by nowcasting_utils
Based off version from predict_pv_yield
…ed under nowcasting_dataset
jacobbieker
changed the title
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR will add support for nowcasting dataset in SatFlow and allow for the training on ML models using that package. It also moves support for various common utils to nowcasting_utils package, and removes them from here.
Fixes #87 Fixes #8
Helps with #91 with the addition of nowcasting_utils and great visualization code from predict_pv_yield to that repo, can probably get that output here easily.
Relies partly on openclimatefix/nowcasting_dataset#107 for having the dataset support. Other option could be just to copy over
NetCDFDatasetand customize here, but then there is some duplicate implementations again.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist: