fix tests

openconfig · Apr 25, 2024 · 58a4624 · 58a4624
1 parent 0363b84
commit 58a4624
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/pkg/api/target_test.go b/pkg/api/target_test.go
@@ -12,7 +12,6 @@ import (
 	"testing"
 
 	"github.com/AlekSi/pointer"
-	"github.com/google/go-cmp/cmp"
 
 	"github.com/openconfig/gnmic/pkg/api/types"
 )
@@ -145,7 +144,7 @@ func TestNewTarget(t *testing.T) {
 				t.Errorf("failed at %q: %v", name, err)
 				t.Fail()
 			}
-			if !cmp.Equal(tg.Config, item.config) {
+			if tg.Config.String() != item.config.String() {
 				t.Errorf("failed at %q", name)
 				t.Errorf("expected %+v", item.config)
 				t.Errorf("     got %+v", tg.Config)

diff --git a/pkg/loaders/loaders_test.go b/pkg/loaders/loaders_test.go
@@ -157,7 +157,22 @@ func TestGetInstancesTagsMatches(t *testing.T) {
 			res := Diff(item.m1, item.m2)
 			t.Logf("exp value: %+v", item.output)
 			t.Logf("got value: %+v", res)
-			if !cmp.Equal(item.output, res) {
+			if len(item.output.Add) != len(res.Add) {
+				t.Fail()
+			}
+			if len(item.output.Del) != len(res.Del) {
+				t.Fail()
+			}
+			for k, v1 := range item.output.Add {
+				if v2, ok := res.Add[k]; ok {
+					if v1.String() != v2.String() {
+						t.Fail()
+					}
+				} else {
+					t.Fail()
+				}
+			}
+			if !cmp.Equal(item.output.Del, res.Del) {
 				t.Fail()
 			}
 		})