Merge pull request #296 from lucabrasi83/fix-consul-loader

Fix Consul Loader panic from #272
openconfig · Nov 14, 2023 · d461fa9 · d461fa9
2 parents 908837c + a687572
commit d461fa9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/loaders/consul_loader/consul_loader.go b/pkg/loaders/consul_loader/consul_loader.go
@@ -377,7 +377,7 @@ func (c *consulLoader) serviceEntryToTargetConfig(se *api.ServiceEntry) (*types.
 SRV:
 	for _, sd := range c.cfg.Services {
 		// match service name
-		if se.Service.Service == sd.Name {
+		if se.Service.Service != sd.Name {
 			continue
 		}
 
@@ -407,7 +407,7 @@ SRV:
 		return tc, nil
 	}
 
-	return nil, nil
+	return nil, errors.New("unable to find a match in Consul service(s)")
 }
 
 func (c *consulLoader) updateTargets(ctx context.Context, srvName string, tcs map[string]*types.TargetConfig, opChan chan *loaders.TargetOperation) {