conformance: pull tests shouldn't rely on tag listing #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynr
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe,
sudo-bmitch and
vbatts
as code owners
|
I haven't had a chance to give this a full review, but CI is failing on the change. |
|
@sudo-bmitch thanks for the heads up, i pushed a commit to fix it. |
|
The overall change LGTM. Would you squash the commits and add the DCO signoff? https://github.com/opencontainers/distribution-spec/pull/476/checks?check_run_id=17356808821 |
waynr
force-pushed
the
dont-rely-on-tag-listing-in-manifest-pull-test
branch
from
fe58bc6 to
c758964
Compare
|
@sudo-bmitch done, thanks! |
Signed-off-by: wayne warren <[email protected]>
dmcgowan
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a fully-implemented container registry yet. I am implementing
endpoints incrementally in order to work toward a fully-functioning
implementation of the spec. This PR removes call to the tag listing endpoint
that was erroneously being relied on to determine the name of a valid tag to
pull.
Instead, I replaced a
tag := ...with atag = ...in an earlier ginkgo casein order to set the outer scopoed
tagvariable used in subsequent taggedmanifest HEAD call. I suspect the tag listing endpoint was added here to
address this apparent
:=vs=bug.