clarify where OCI-Chunk-Min-Length response headers are expected #481
Conversation
mvdan
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe,
sudo-bmitch and
vbatts
as code owners
The first section speaks about a chunked upload with three stages of HTTP requests (POST, PATCH, PUT), so the wording "the response" is ambiguous as to which one of the three requests it's for. The conformance tests seem to imply POST, and that is what makes the most sense to me - if the server only gives the minimum after the first PATCH or PUT, the client might have already written chunks which are too small without realising. Another bit of the spec talks about the same header, but refers explicitly to the PUT response of a chunked upload. This again doesn't feel right: I think POST was meant instead. Giving the minimum as part of the final PUT response is pointless, since the client isn't writing any more chunks after that point. Signed-off-by: Daniel Martí <[email protected]>
|
From a practical point of view, I suspect the GET response to find the current offset should also return the chunk length, to better support stateless client resumption of uploads, but I've no idea if that's actually a current convention or not. |
|
The idea of setting this on the |
|
Should I do anything else to get this tiny clarification merged? Hopefully eight reviews aren't actually necessary :) |
It just needs a second maintainer to approve. Copying the commit message into the PR may get more attention. |
(see commit message)