Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.0.2 #1037

Merged
merged 4 commits into from
Mar 27, 2020
Merged

Release v1.0.2 #1037

merged 4 commits into from
Mar 27, 2020

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Mar 24, 2020 •
edited
Loading

@crosbymichael
Copy link
Member

crosbymichael commented Mar 24, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

1 similar comment
@tianon
Copy link
Member

tianon commented Mar 24, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

h-vetinari
h-vetinari reviewed Mar 25, 2020
View reviewed changes
ChangeLog Show resolved Hide resolved
@vbatts vbatts force-pushed the bumpversion_v1.0.2 branch from 8068586 to 4bc6673 Compare March 25, 2020 11:43
@vbatts
Copy link
Member Author

vbatts commented Mar 25, 2020

Updated, PTAL
thanks @h-vetinari for the ChangeLog update

@h-vetinari
Copy link
Contributor

h-vetinari commented Mar 25, 2020 •
edited
Loading

@vbatts, I think you need to rebase and reorder the patches (in case you want the changelog to be complete for the tagged version) - you applied my suggestion after setting the version 1.0.2.

PS. If you want, you can use: Co-Authored-By: H. Vetinari <[email protected]> instead of Co-Authored-By: h-vetinari <[email protected]>
PPS. I would also be fine if you just squash my update into your changelog commit, I don't need attribution for this trivial patch.

vbatts and others added 3 commits March 25, 2020 07:57
@vbatts @h-vetinari
ChangeLog: changes v1.0.1...v1.0.2
ce773cb 
Co-Authored-By: H. Vetinari <[email protected]>
Signed-off-by: Vincent Batts <[email protected]>
@vbatts
specs-go: update version to 1.0.2
c4ee7d1 
Signed-off-by: Vincent Batts <[email protected]>
@vbatts
specs-go: bump master back to -dev
1ac6f8d 
Signed-off-by: Vincent Batts <[email protected]>
@vbatts vbatts force-pushed the bumpversion_v1.0.2 branch from 4bc6673 to 1ac6f8d Compare March 25, 2020 11:59
@vbatts
Copy link
Member Author

vbatts commented Mar 25, 2020

right again. This updates the commit that @tianon already corrected me about, but I think this is fine. 😬
new tagged v1.0.2 would be on c4ee7d1

@tianon
Copy link
Member

tianon commented Mar 25, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael
Copy link
Member

crosbymichael commented Mar 27, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@vbatts vbatts merged commit 2a06026 into opencontainers:master Mar 27, 2020
@vbatts vbatts deleted the bumpversion_v1.0.2 branch March 27, 2020 15:40
@h-vetinari
Copy link
Contributor

Congrats everyone for getting this one out the door!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag a new release
4 participants
@vbatts @crosbymichael @tianon @h-vetinari