Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation: add tests for NSNewNSWithoutPath & NSInheritWithoutType #620

Merged

Commits on Apr 17, 2018

  1. validation: add a new test for NSNewNSWithoutPath

    This test is to check for NSNewNSWithoutPath, i.e. "If path is not
    specified, the runtime MUST create a new container namespace of the
    given type"
    
    See also opencontainers#572
    
    Signed-off-by: Dongsu Park <[email protected]>
    Dongsu Park committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    5ce0ff8 View commit details
    Browse the repository at this point in the history
  2. validation: add a new test for NSInheritWithoutType

    This test is to check for NSInheritWithoutType, i.e. "If a namespace
    type is not specified in the namespaces array, the container MUST
    inherit the runtime namespace of that type".
    
    See also opencontainers#572
    
    Signed-off-by: Dongsu Park <[email protected]>
    Dongsu Park committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    d7985e3 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. validation: split out pringDiag from testNamespaceNoPath

    To be able to deal with diagnostics in a general way, split out the diagnostics
    handling code into a new function `pringDiag()`, which will be normally called
    from the defer function's context. This way we can simplify the error handling
    routines.
    
    Signed-off-by: Dongsu Park <[email protected]>
    Dongsu Park committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    1ac1c02 View commit details
    Browse the repository at this point in the history
  2. validation: split out pringDiag from testNamespaceInheritType

    To be able to deal with diagnostics in a general way, split out the diagnostics
    handling code into a new function `pringDiag()`, which will be normally called
    from the defer function's context. This way we can simplify the error handling
    routines.
    
    Signed-off-by: Dongsu Park <[email protected]>
    Dongsu Park committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    e830fa3 View commit details
    Browse the repository at this point in the history